Support for proxies and load balancers #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IP address), plus the HTTP_X_FORWARDED_FOR header if present (which is set by some proxy servers and load balancers). This allows us to have a unique per-user view, even when behind a proxy or load balancer.
|
I like the idea, though in cases where Also, might be better (for readability) to separate by [space][dash][space] rather than [comma][space]. |
|
@yellis - no problem at all. New commit added. Cheers. |
yellis
added a commit
that referenced
this pull request
May 29, 2014
Support for proxies and load balancers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine both the REMOTE_ADDR header (which is the connecting device's IP address), plus the HTTP_X_FORWARDED_FOR header if present (which is set by some proxy servers and load balancers) when determining the user's IP address. This allows us to have a unique per-user view, even when behind a proxy or load balancer.